feat(notification): add sound player executable option (#1301)

Pass the path to the player executable as a players array to play-sound so that it will check if the executable exists.
This commit is contained in:
Warwick Marangos
2020-12-09 20:59:10 -05:00
committed by GitHub
parent 3841666d03
commit 8d192317ba
3 changed files with 5 additions and 1 deletions
+1
View File
@@ -8,6 +8,7 @@ You can test your notification configuration by running `npm run test:notificati
|---|---|
| `DESKTOP_NOTIFICATIONS` | Display desktop notifications using [node-notifier](https://www.npmjs.com/package/node-notifier). |
| `PLAY_SOUND` | Play this sound notification if a product is found. Relative path accepted, valid formats: wav, mp3, flac, E.g.: `path/to/notification.wav`, [free sounds available](https://notificationsounds.com/) |
| `SOUND_PLAYER` | Override the default sound player using the specified executable. |
???+ attention
If you're on Windows, you must have the proper library to run.
+1
View File
@@ -270,6 +270,7 @@ const notifications = {
channel: envOrString(process.env.SLACK_CHANNEL),
token: envOrString(process.env.SLACK_TOKEN)
},
soundPlayer: envOrString(process.env.SOUND_PLAYER),
telegram: {
accessToken: envOrString(process.env.TELEGRAM_ACCESS_TOKEN),
chatId: envOrArray(process.env.TELEGRAM_CHAT_ID)
+3 -1
View File
@@ -6,7 +6,9 @@ import {logger} from '../logger';
let player: PlaySound;
if (config.notifications.playSound) {
player = playerLib();
player = config.notifications.soundPlayer
? playerLib({players: [config.notifications.soundPlayer]})
: playerLib();
if (player.player === null) {
logger.warn("✖ couldn't find sound player");