refactor: add more types to Model, extract Brand

This is prep work for normalizing `Model`

Signed-off-by: Jef LeCompte <jeffreylec@gmail.com>
This commit is contained in:
Jef LeCompte
2020-11-10 10:53:24 -05:00
parent 318e626e78
commit 0904253cc6
+50 -26
View File
@@ -10,6 +10,23 @@ export type Pricing = {
euroFormat?: boolean; euroFormat?: boolean;
}; };
export type Brand =
| 'test:brand'
| 'amd'
| 'asus'
| 'evga'
| 'gainward'
| 'gigabyte'
| 'inno3d'
| 'kfa2'
| 'microsoft'
| 'msi'
| 'nvidia'
| 'palit'
| 'pny'
| 'sony'
| 'zotac';
export type Series = export type Series =
| 'test:series' | 'test:series'
| '3070' | '3070'
@@ -32,6 +49,7 @@ export type Model =
| '5950x' | '5950x'
| 'amp extreme holo' | 'amp extreme holo'
| 'amp holo' | 'amp holo'
| 'aorus'
| 'aorus master' | 'aorus master'
| 'aorus xtreme' | 'aorus xtreme'
| 'dual' | 'dual'
@@ -39,14 +57,19 @@ export type Model =
| 'dual oc' | 'dual oc'
| 'founders edition' | 'founders edition'
| 'ftw3' | 'ftw3'
| 'ftw3 gaming'
| 'ftw3 ultra' | 'ftw3 ultra'
| 'ftw3 ultra gaming'
| 'eagle' | 'eagle'
| 'eagle oc' | 'eagle oc'
| 'gaming' | 'gaming'
| 'gaming oc' | 'gaming oc'
| 'gaming x3' | 'gaming x3'
| 'ichill x2'
| 'ichill x3' | 'ichill x3'
| 'ichill 3x'
| 'ichill x4' | 'ichill x4'
| 'ichill 4x'
| 'gamerock oc' | 'gamerock oc'
| 'gaming x trio' | 'gaming x trio'
| 'gaming pro' | 'gaming pro'
@@ -58,48 +81,49 @@ export type Model =
| 'phoenix gs' | 'phoenix gs'
| 'phoenix gs oc' | 'phoenix gs oc'
| 'rog strix' | 'rog strix'
| 'rog strix gaming'
| 'rog strix oc' | 'rog strix oc'
| 'rog strix oc gaming'
| 'sg oc' | 'sg oc'
| 'tuf' | 'sg-oc'
| 'tuf oc' | 'strix gaming'
| 'turbo' | 'strix gaming oc'
| 'ventus 2s oc'
| 'ventus 3x'
| 'ventus 3x oc'
| 'trinity' | 'trinity'
| 'trinity oc' | 'trinity oc'
| 'tuf'
| 'tuf gaming'
| 'tuf gaming oc'
| 'tuf oc'
| 'tuf oc gaming'
| 'turbo'
| 'twin edge' | 'twin edge'
| 'twin edge oc' | 'twin edge oc'
| 'twin x2'
| 'twin x2 oc' | 'twin x2 oc'
| 'uprising'
| 'ventus 2x'
| 'ventus 2x oc'
| 'ventus 3x'
| 'ventus 3x oc'
| 'vision' | 'vision'
| 'vision oc' | 'vision oc'
| 'xc3' | 'xc3'
| 'xc3 gaming'
| 'xc3 black'
| 'xc3 black gaming'
| 'xc3 ultra' | 'xc3 ultra'
| 'xboxss' | 'xc3 ultra gaming'
| 'xboxsx' | 'xbox series s'
| 'xbox series x'
| 'xlr8' | 'xlr8'
| 'xlr8 rgb'; | 'xlr8 rgb'
| 'xlr8 uprising';
export type Link = { export type Link = {
brand: brand: Brand;
| 'test:brand'
| 'amd'
| 'asus'
| 'evga'
| 'gainward'
| 'gigabyte'
| 'inno3d'
| 'kfa2'
| 'microsoft'
| 'msi'
| 'nvidia'
| 'palit'
| 'pny'
| 'sony'
| 'zotac';
itemNumber?: string; itemNumber?: string;
series: Series; series: Series;
model: string; model: Model | string;
url: string; url: string;
cartUrl?: string; cartUrl?: string;
openCartAction?: (browser: Browser) => Promise<string>; openCartAction?: (browser: Browser) => Promise<string>;