API Silent Merge fail

This commit is contained in:
ivan-pelly
2026-02-21 10:57:12 -08:00
parent c71d8911ac
commit 8304d65e65
10 changed files with 82 additions and 25 deletions
+3 -3
View File
@@ -5,14 +5,14 @@ namespace WinStudentGoalTracker.BaseClasses;
public class BaseController : ControllerBase
{
protected (int userId, ActionResult? error) GetUserIdFromClaims()
protected (Guid userId, ActionResult? error) GetUserIdFromClaims()
{
var userIdClaim = User.FindFirst("user_id")?.Value
?? User.FindFirst(ClaimTypes.NameIdentifier)?.Value;
if (string.IsNullOrWhiteSpace(userIdClaim) || !int.TryParse(userIdClaim, out var userId))
if (string.IsNullOrWhiteSpace(userIdClaim) || !Guid.TryParse(userIdClaim, out var userId))
{
return (0, Unauthorized("Missing or invalid user_id claim."));
return (Guid.Empty, Unauthorized("Missing or invalid user_id claim."));
}
return (userId, null);
+6 -6
View File
@@ -29,10 +29,10 @@ public class StudentController : BaseController
});
}
[HttpGet("{idStudent:int}")]
[HttpGet("{idStudent:guid}")]
[ProducesResponseType(typeof(ResponseResult<StudentResponse>), StatusCodes.Status200OK)]
[ProducesResponseType(typeof(ResponseResult<StudentResponse>), StatusCodes.Status404NotFound)]
public async Task<ActionResult<ResponseResult<StudentResponse>>> GetById(int idStudent)
public async Task<ActionResult<ResponseResult<StudentResponse>>> GetById(Guid idStudent)
{
var student = await _studentRepository.GetByIdAsync(idStudent);
if (student is null)
@@ -84,10 +84,10 @@ public class StudentController : BaseController
});
}
[HttpPut("{idStudent:int}")]
[HttpPut("{idStudent:guid}")]
[ProducesResponseType(typeof(ResponseResult<StudentResponse>), StatusCodes.Status200OK)]
[ProducesResponseType(typeof(ResponseResult<StudentResponse>), StatusCodes.Status404NotFound)]
public async Task<ActionResult<ResponseResult<StudentResponse>>> Update(int idStudent, [FromBody] UpdateStudentDto request)
public async Task<ActionResult<ResponseResult<StudentResponse>>> Update(Guid idStudent, [FromBody] UpdateStudentDto request)
{
var existing = await _studentRepository.GetByIdAsync(idStudent);
if (existing is null)
@@ -118,10 +118,10 @@ public class StudentController : BaseController
});
}
[HttpDelete("{idStudent:int}")]
[HttpDelete("{idStudent:guid}")]
[ProducesResponseType(typeof(ResponseResult<object>), StatusCodes.Status200OK)]
[ProducesResponseType(typeof(ResponseResult<object>), StatusCodes.Status404NotFound)]
public async Task<ActionResult<ResponseResult<object>>> Delete(int idStudent)
public async Task<ActionResult<ResponseResult<object>>> Delete(Guid idStudent)
{
var deleted = await _studentRepository.DeleteAsync(idStudent);
if (!deleted)
@@ -2,8 +2,8 @@ namespace WinStudentGoalTracker.DataAccess;
public class CreateStudentDto
{
public required int IdStudent { get; set; }
public int? IdProgram { get; set; }
public required Guid IdStudent { get; set; }
public Guid? IdProgram { get; set; }
public string? Identifier { get; set; }
public int? ProgramYear { get; set; }
public DateTime? EnrollmentDate { get; set; }
@@ -2,7 +2,7 @@ namespace WinStudentGoalTracker.DataAccess;
public class UpdateStudentDto
{
public int? IdProgram { get; set; }
public Guid? IdProgram { get; set; }
public string? Identifier { get; set; }
public int? ProgramYear { get; set; }
public DateTime? EnrollmentDate { get; set; }
@@ -2,8 +2,8 @@ namespace WinStudentGoalTracker.DataAccess;
public class dbStudent
{
public required int IdStudent { get; set; }
public int? IdProgram { get; set; }
public required Guid IdStudent { get; set; }
public Guid? IdProgram { get; set; }
public string? Identifier { get; set; }
public int? ProgramYear { get; set; }
public DateTime? EnrollmentDate { get; set; }
@@ -16,12 +16,12 @@ public class StudentRepository
commandType: CommandType.StoredProcedure);
}
public async Task<dbStudent?> GetByIdAsync(int idStudent)
public async Task<dbStudent?> GetByIdAsync(Guid idStudent)
{
using var db = Connection;
return await db.QuerySingleOrDefaultAsync<dbStudent>(
"sp_Student_GetById",
new { p_id_student = idStudent },
new { p_id_student = idStudent.ToString() },
commandType: CommandType.StoredProcedure);
}
@@ -32,8 +32,8 @@ public class StudentRepository
"sp_Student_Insert",
new
{
p_id_student = dto.IdStudent,
p_id_program = dto.IdProgram,
p_id_student = dto.IdStudent.ToString(),
p_id_program = dto.IdProgram?.ToString(),
p_identifier = dto.Identifier,
p_program_year = dto.ProgramYear,
p_enrollment_date = dto.EnrollmentDate,
@@ -42,15 +42,15 @@ public class StudentRepository
commandType: CommandType.StoredProcedure);
}
public async Task<bool> UpdateAsync(int idStudent, UpdateStudentDto dto)
public async Task<bool> UpdateAsync(Guid idStudent, UpdateStudentDto dto)
{
using var db = Connection;
var rowsAffected = await db.ExecuteScalarAsync<int>(
"sp_Student_Update",
new
{
p_id_student = idStudent,
p_id_program = dto.IdProgram,
p_id_student = idStudent.ToString(),
p_id_program = dto.IdProgram?.ToString(),
p_identifier = dto.Identifier,
p_program_year = dto.ProgramYear,
p_enrollment_date = dto.EnrollmentDate,
@@ -60,12 +60,12 @@ public class StudentRepository
return rowsAffected > 0;
}
public async Task<bool> DeleteAsync(int idStudent)
public async Task<bool> DeleteAsync(Guid idStudent)
{
using var db = Connection;
var rowsAffected = await db.ExecuteScalarAsync<int>(
"sp_Student_Delete",
new { p_id_student = idStudent },
new { p_id_student = idStudent.ToString() },
commandType: CommandType.StoredProcedure);
return rowsAffected > 0;
}
@@ -4,8 +4,8 @@ namespace WinStudentGoalTracker.Models;
public class StudentResponse
{
public int IdStudent { get; set; }
public int? IdProgram { get; set; }
public Guid IdStudent { get; set; }
public Guid? IdProgram { get; set; }
public string? Identifier { get; set; }
public int? ProgramYear { get; set; }
public DateTime? EnrollmentDate { get; set; }