From 2ae8bc6d994923d9ac5205be43bcbf8bf73cad85 Mon Sep 17 00:00:00 2001
From: ivan-pelly <ivan.pelly@gmail.com>
Date: Sun, 15 Mar 2026 10:01:36 -0700
Subject: [PATCH] Update mobile view

---
 db/Migrations/add_benchmark_short_name.sql    | 94 -------------------
 .../src/app/mobile/pages/students/students.ts |  5 +-
 2 files changed, 4 insertions(+), 95 deletions(-)
 delete mode 100644 db/Migrations/add_benchmark_short_name.sql

diff --git a/db/Migrations/add_benchmark_short_name.sql b/db/Migrations/add_benchmark_short_name.sql
deleted file mode 100644
index a3945da..0000000
--- a/db/Migrations/add_benchmark_short_name.sql
+++ /dev/null
@@ -1,94 +0,0 @@
--- =====================================================================
--- Migration: Add short_name column to benchmark table and update
--- all benchmark stored procedures to support it.
--- Run in TablePlus against MySQL.
--- =====================================================================
-
--- 1. Add the column
-ALTER TABLE `benchmark`
-ADD COLUMN `short_name` VARCHAR(50) DEFAULT NULL AFTER `benchmark`;
-
-
--- 2. Recreate sp_Benchmark_GetByStudentId
-DROP PROCEDURE IF EXISTS `sp_Benchmark_GetByStudentId`;
-CREATE PROCEDURE `sp_Benchmark_GetByStudentId`(IN p_id_student CHAR(36))
-BEGIN
-    SELECT
-        s.`identifier`          AS `studentIdentifier`,
-        b.`id_benchmark`        AS `benchmarkId`,
-        b.`id_goal`             AS `goalId`,
-        g.`category`            AS `goalCategory`,
-        b.`benchmark`           AS `benchmark`,
-        b.`short_name`          AS `shortName`,
-        u.`name`                AS `createdByName`,
-        b.`created_at`          AS `createdAt`,
-        b.`updated_at`          AS `updatedAt`
-    FROM `benchmark` b
-    INNER JOIN `goal` g ON g.`id_goal` = b.`id_goal`
-    INNER JOIN `student` s ON s.`id_student` = g.`id_student`
-    LEFT JOIN `user` u ON u.`id_user` = b.`id_user_created`
-    WHERE g.`id_student` = p_id_student
-    ORDER BY b.`created_at` DESC;
-END;
-
-
--- 3. Recreate sp_Benchmark_Insert
-DROP PROCEDURE IF EXISTS `sp_Benchmark_Insert`;
-CREATE PROCEDURE `sp_Benchmark_Insert`(
-    IN p_id_benchmark CHAR(36),
-    IN p_id_goal CHAR(36),
-    IN p_id_user_created CHAR(36),
-    IN p_benchmark TEXT,
-    IN p_short_name VARCHAR(50)
-)
-BEGIN
-    INSERT INTO benchmark
-    (
-        id_benchmark,
-        id_goal,
-        id_user_created,
-        benchmark,
-        short_name,
-        created_at,
-        updated_at
-    )
-    VALUES
-    (
-        p_id_benchmark,
-        p_id_goal,
-        p_id_user_created,
-        p_benchmark,
-        p_short_name,
-        UTC_TIMESTAMP(),
-        NULL
-    );
-    SELECT
-        id_benchmark,
-        id_goal,
-        id_user_created,
-        benchmark,
-        short_name,
-        created_at,
-        updated_at
-    FROM benchmark
-    WHERE id_benchmark = p_id_benchmark
-    LIMIT 1;
-END;
-
-
--- 4. Recreate sp_Benchmark_Update
-DROP PROCEDURE IF EXISTS `sp_Benchmark_Update`;
-CREATE PROCEDURE `sp_Benchmark_Update`(
-    IN p_id_benchmark CHAR(36),
-    IN p_benchmark TEXT,
-    IN p_short_name VARCHAR(50)
-)
-BEGIN
-    UPDATE benchmark
-    SET
-        benchmark = p_benchmark,
-        short_name = p_short_name,
-        updated_at = UTC_TIMESTAMP()
-    WHERE id_benchmark = p_id_benchmark;
-    SELECT ROW_COUNT() AS rowsAffected;
-END;
diff --git a/ui/winstudentgoaltracker/src/app/mobile/pages/students/students.ts b/ui/winstudentgoaltracker/src/app/mobile/pages/students/students.ts
index 07a2b0c..6c2a616 100644
--- a/ui/winstudentgoaltracker/src/app/mobile/pages/students/students.ts
+++ b/ui/winstudentgoaltracker/src/app/mobile/pages/students/students.ts
@@ -46,7 +46,10 @@ export class Students {
       }
       else
       {
-        this.students.set(data.payload || []);
+        const sorted = (data.payload || []).sort((a, b) =>
+          a.identifier.localeCompare(b.identifier, undefined, { sensitivity: 'base' })
+        );
+        this.students.set(sorted);
         this.loaded.set(true);
       }
     });