5e8a49f7f2
Restore lambda and gradient function post-merge and minor fixes.
...
bench: 3788313
2020-09-26 12:55:02 +09:00
c99541828f
Remove the re-search on depth 0. It is correctly handled by search now.
2020-09-25 16:06:33 +02:00
b6e7733b4c
In gensfen call search before get_current_game_result so that rootMoves is initialized by Learner::init_for_search. Don't call Tablebases::rank_root_moves in get_current_game_result because it's called in Learner::init_for_search. This fixes accessing uninitialized variables related to tablebases.
2020-09-25 15:04:21 +02:00
9f3de8b40e
Revert some unwanted changes from merge conflict resolution.
2020-09-24 21:10:10 +02:00
9827411b7c
Merge remote-tracking branch 'remotes/nodchip/master' into trainer
2020-09-24 21:45:28 +08:00
5be8b573be
Merge remote-tracking branch 'remotes/origin/master' into trainer
2020-09-23 19:02:27 +08:00
411adab149
Merge remote-tracking branch 'remotes/nodchip/master' into trainer
2020-09-23 18:29:30 +08:00
2931463d3a
Revert earlier TB changes.
...
they were not correct. Unfortunately, also restores the race on RootInTB
2020-09-21 09:45:42 +09:00
da28ce3339
Add initialization also to learning patch
...
fixes https://github.com/nodchip/Stockfish/issues/160
2020-09-20 08:16:54 +09:00
61bc8d12d3
Fix some races in learning
...
declare a few variables atomic.
Other races remain...
2020-09-19 10:09:30 +09:00
e8472b5fbe
Fix races in gensfen as detected with thread sanitizer.
...
RootInTB was an incorrectly shared global, probably leading to wrong scoreing
Minor:
setting TB global state from input by all threads (all threads write same values)
setting Limits global state by all threads (idem)
thread counting for finalization
CI can be enabled once races are fixed in the learner, manually goes like:
```
make clean && make -j2 ARCH=x86-64-modern sanitize=thread optimize=no debug=yes build
../tests/instrumented_learn.sh --sanitizer-thread
```
Needs some review.
2020-09-19 10:08:44 +09:00
a47a3bfc7c
Merge remote-tracking branch 'remotes/nodchip/master' into trainer
2020-09-19 02:14:17 +08:00
184bde47dc
Add "seed" option to gensfen and learn
2020-09-16 23:09:45 +09:00
6ae09ba266
Fixed a bug that the root color is wrong.
2020-09-16 12:10:35 +09:00
0f270f7cbf
Merge branch 'master' into no_eval_learn
2020-09-13 13:36:16 +02:00
a94a076e39
Fixed a comment.
2020-09-13 16:35:52 +09:00
1c84da9caa
Fixed a bug that an assertion fails in the trainer. if the SkipLoading is false.
...
Fixes #128
2020-09-13 16:32:01 +09:00
d33e7a9b07
Remove conditional compilation on EVAL_LEARN
2020-09-12 16:19:24 +02:00
580b09381b
Add a learning command to CI
...
fixes a small issue, with ponder
Probably the learning command can be improved a bit, so that despite the limited data, the code coverage is better.
2020-09-12 22:25:36 +09:00
bcfe28b2ae
Fix compilation of sfen_packer.cpp in debug.
2020-09-11 21:53:17 +09:00
98f24570ab
Add src to include paths, remove non-standard ".." in includes in learn directory.
2020-09-11 21:53:17 +09:00
96fa8fa8dc
Add missing files.
2020-09-11 21:53:17 +09:00
683c6146ce
Move declarations around and split them.
2020-09-11 21:53:17 +09:00
c6f5f6a082
Replace "use_raw_nnue_eval" with an uci option "Use NNUE pure"
2020-09-11 21:53:17 +09:00
c76bb34a96
Add convert UCI function that allows conversion of files between any of plain, bin, and binpack. Usage: convert infile outfile [append].
2020-09-11 09:36:24 +09:00
6b76ebc2ca
Support for binpack format in sfenreader in learner. Automatically detect file extension and choose the correct reader (bin or binpack)
2020-09-10 21:19:37 +09:00
020e66d2e6
Add "sfen_format" option in gensfen. Valid values are "bin" and "binpack". It determines the output format of the sfens. Binpack is a highly compressed formats for consecutive sfens. Extension is now determined by the used format, output_file_name should contain just the stem.
2020-09-10 21:19:37 +09:00
9dcadfa642
Removed compile warnings.
2020-09-09 23:02:39 +09:00
7bd4688747
Remove compile warnings.
2020-09-09 23:02:39 +09:00
b3a0ded37a
Merge remote-tracking branch 'remotes/nodchip/master' into trainer
2020-09-09 21:42:45 +08:00
84ba591118
Merge branch 'master' into trainer
2020-09-09 20:19:13 +08:00
17d42e023e
add more CI, instrumented runs
2020-09-09 19:40:43 +09:00
675d336ebb
Merge branch 'master' into trainer
2020-09-09 16:08:49 +08:00
2583f68972
Removed macros for KPP evaluate functions.
2020-09-09 10:26:42 +09:00
8d763fb503
Removed LEARN_GENSFEN_USE_DRAW_RESULT macro.
2020-09-09 10:26:42 +09:00
eafa569365
Removed macros for KPP factorization.
2020-09-09 10:26:42 +09:00
5e25702672
Removed USE_TRIANGLE_WEIGHT_ARRAY macro.
2020-09-09 10:26:42 +09:00
f52165e1d3
Removed RESET_TO_ZERO_VECTOR macro.
2020-09-09 10:26:42 +09:00
dbad9d96e0
Removed LOSS_FUNCTION_IS_ELMO_METHOD macro.
2020-09-09 10:26:42 +09:00
ef1601218d
Removed LOSS_FUNCTION_IS_CROSS_ENTOROPY_FOR_VALUE macro.
2020-09-09 10:26:42 +09:00
f52fbf8006
Removed LOSS_FUNCTION_IS_CROSS_ENTOROPY macro.
2020-09-09 10:26:42 +09:00
d37eb63581
Removed LOSS_FUNCTION_IS_WINNING_PERCENTAGE macro.
2020-09-09 10:26:42 +09:00
f3a158725d
Removed SGD_UPDATE macro.
2020-09-09 10:26:42 +09:00
0271d70775
Removed ADA_GRAD_UPDATE macro.
2020-09-09 10:26:42 +09:00
05d26499b4
Removed LEARN_ELMO_METHOD macro.
2020-09-09 10:26:42 +09:00
82dc68ba9f
Removed #if for USE_GLOBAL_OPTIONS.
2020-09-09 10:26:42 +09:00
aa2452caf3
Removed #if for USE_EVAL_HASH.
2020-09-09 10:26:42 +09:00
ec96409176
Replaced DNDEBUG macro to _DEBUG macro.
2020-09-09 10:26:42 +09:00
04a9a951b8
Removed "#if 0" and "#if 1".
2020-09-09 10:26:42 +09:00
21cfead52c
Removed unused OMP_ macro.
2020-09-09 10:26:42 +09:00
noobpwnftw