opelly/Stockfish
1
0
Fork 0
mirror of https://github.com/opelly27/Stockfish.git synced 2026-05-20 06:17:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't need to assert for pos.is_ok() when position is constant

Browse Source 
It's only necessary to do the checking at the end of every non-const
member (including the constructors and from_fen()) of class Position.
Once the post-condition of every modifier guarantees the class invariant,
we don't need to verify sanity of the position as preconditions for outside
callers such as movegen, search etc. For non-class types such as Move and
Square we still need to assert of course.

Suggested by Rein Halbersma.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
This commit is contained in:
Marco Costalba
2011-07-16 10:42:27 +01:00
parent 69f4954df1
commit 67686b7684
7 changed files with 13 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/position.cpp
+10 -10
View File
@@ -103,6 +103,8 @@ Position::Position(const Position& pos, int th) {
detach(); // Always detach() in copy c'tor to avoid surprises
threadID = th;
nodes = 0;
assert(is_ok());
}
Position::Position(const string& fen, bool isChess960, int th) {
@@ -214,6 +216,8 @@ void Position::from_fen(const string& fenStr, bool isChess960) {
st->value = compute_value();
st->npMaterial[WHITE] = compute_non_pawn_material(WHITE);
st->npMaterial[BLACK] = compute_non_pawn_material(BLACK);
assert(is_ok());
}
@@ -492,7 +496,6 @@ bool Position::move_attacks_square(Move m, Square s) const {
bool Position::pl_move_is_legal(Move m, Bitboard pinned) const {
assert(is_ok());
assert(move_is_ok(m));
assert(pinned == pinned_pieces());
@@ -559,8 +562,6 @@ bool Position::move_is_legal(const Move m) const {
bool Position::move_is_pl(const Move m) const {
assert(is_ok());
Color us = sideToMove;
Color them = opposite_color(sideToMove);
Square from = move_from(m);
@@ -683,7 +684,6 @@ bool Position::move_is_pl(const Move m) const {
bool Position::move_gives_check(Move m, const CheckInfo& ci) const {
assert(is_ok());
assert(move_is_ok(m));
assert(ci.dcCandidates == discovered_check_candidates());
assert(piece_color(piece_on(move_from(m))) == side_to_move());
@@ -794,6 +794,8 @@ void Position::do_setup_move(Move m) {
// Our StateInfo newSt is about going out of scope so copy
// its content before it disappears.
detach();
assert(is_ok());
}
@@ -809,7 +811,6 @@ void Position::do_move(Move m, StateInfo& newSt) {
void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveIsCheck) {
assert(is_ok());
assert(move_is_ok(m));
assert(&newSt != st);
@@ -1181,7 +1182,6 @@ void Position::do_castle_move(Move m) {
void Position::undo_move(Move m) {
assert(is_ok());
assert(move_is_ok(m));
sideToMove = opposite_color(sideToMove);
@@ -1355,7 +1355,6 @@ void Position::undo_castle_move(Move m) {
void Position::do_null_move(StateInfo& backupSt) {
assert(is_ok());
assert(!in_check());
// Back up the information necessary to undo the null move to the supplied
@@ -1385,6 +1384,8 @@ void Position::do_null_move(StateInfo& backupSt) {
st->rule50++;
st->pliesFromNull = 0;
st->value += (sideToMove == WHITE) ? TempoValue : -TempoValue;
assert(is_ok());
}
@@ -1392,7 +1393,6 @@ void Position::do_null_move(StateInfo& backupSt) {
void Position::undo_null_move() {
assert(is_ok());
assert(!in_check());
// Restore information from the our backup StateInfo object
@@ -1407,6 +1407,8 @@ void Position::undo_null_move() {
sideToMove = opposite_color(sideToMove);
st->rule50--;
st->gamePly--;
assert(is_ok());
}
@@ -1757,8 +1759,6 @@ void Position::init() {
void Position::flip() {
assert(is_ok());
// Make a copy of current position before to start changing
const Position pos(*this, threadID);