PascalCase -> snake_case for consistency with the rest of the codebase.

src/nnue/features/castling_right.cpp

@@ -5,8 +5,11 @@
 namespace Eval::NNUE::Features {
 
     // Get a list of indices with a value of 1 among the features
-    void CastlingRight::AppendActiveIndices(
-        const Position& pos, Color perspective, IndexList* active) {
+    void CastlingRight::append_active_indices(
+        const Position& pos,
+        Color perspective,
+        IndexList* active) {
+
         // do nothing if array size is small to avoid compiler warning
         if (RawFeatures::kMaxActiveDimensions < kMaxActiveDimensions) return;
 
@@ -29,9 +32,11 @@ namespace Eval::NNUE::Features {
     }
 
     // Get a list of indices whose values ​​have changed from the previous one in the feature quantity
-    void CastlingRight::AppendChangedIndices(
-        const Position& pos, Color perspective,
-        IndexList* removed, IndexList* /* added */) {
+    void CastlingRight::append_changed_indices(
+        const Position& pos,
+        Color perspective,
+        IndexList* removed,
+        IndexList* /* added */) {
 
         int previous_castling_rights = pos.state()->previous->castlingRights;
         int current_castling_rights = pos.state()->castlingRights;

src/nnue/features/castling_right.h

@@ -26,12 +26,17 @@ namespace Eval::NNUE::Features {
         static constexpr TriggerEvent kRefreshTrigger = TriggerEvent::kNone;
 
         // Get a list of indices with a value of 1 among the features
-        static void AppendActiveIndices(const Position& pos, Color perspective,
+        static void append_active_indices(
+            const Position& pos,
+            Color perspective,
             IndexList* active);
 
         // Get a list of indices whose values ​​have changed from the previous one in the feature quantity
-        static void AppendChangedIndices(const Position& pos, Color perspective,
-            IndexList* removed, IndexList* added);
+        static void append_changed_indices(
+            const Position& pos,
+            Color perspective,
+            IndexList* removed,
+            IndexList* added);
     };
 
 }  // namespace Eval::NNUE::Features

src/nnue/features/enpassant.cpp

@@ -5,8 +5,10 @@
 namespace Eval::NNUE::Features {
 
     // Get a list of indices with a value of 1 among the features
-    void EnPassant::AppendActiveIndices(
-        const Position& pos, Color /* perspective */, IndexList* active) {
+    void EnPassant::append_active_indices(
+        const Position& pos,
+        Color /* perspective */,
+        IndexList* active) {
 
         // do nothing if array size is small to avoid compiler warning
         if (RawFeatures::kMaxActiveDimensions < kMaxActiveDimensions)
@@ -21,9 +23,11 @@ namespace Eval::NNUE::Features {
     }
 
     // Get a list of indices whose values ​​have changed from the previous one in the feature quantity
-    void EnPassant::AppendChangedIndices(
-        const Position& pos, Color /* perspective */,
-        IndexList* removed, IndexList* added) {
+    void EnPassant::append_changed_indices(
+        const Position& pos,
+        Color /* perspective */,
+        IndexList* removed,
+        IndexList* added) {
 
         auto previous_epSquare = pos.state()->previous->epSquare;
         auto epSquare = pos.state()->epSquare;

src/nnue/features/enpassant.h

@@ -22,12 +22,17 @@ namespace Eval::NNUE::Features {
         static constexpr TriggerEvent kRefreshTrigger = TriggerEvent::kNone;
 
         // Get a list of indices with a value of 1 among the features
-        static void AppendActiveIndices(const Position& pos, Color perspective,
+        static void append_active_indices(
+            const Position& pos,
+            Color perspective,
             IndexList* active);
 
         // Get a list of indices whose values have changed from the previous one in the feature quantity
-        static void AppendChangedIndices(const Position& pos, Color perspective,
-            IndexList* removed, IndexList* added);
+        static void append_changed_indices(
+            const Position& pos,
+            Color perspective,
+            IndexList* removed,
+            IndexList* added);
     };
 
 }  // namespace Eval::NNUE::Features

src/nnue/features/feature_set.h

@@ -33,8 +33,8 @@ namespace Eval::NNUE::Features {
 
     template <typename T, T First, T... Remaining>
     struct CompileTimeList<T, First, Remaining...> {
-        static constexpr bool Contains(T value) {
-            return value == First || CompileTimeList<T, Remaining...>::Contains(value);
+        static constexpr bool contains(T value) {
+            return value == First || CompileTimeList<T, Remaining...>::contains(value);
         }
 
         static constexpr std::array<T, sizeof...(Remaining) + 1>
@@ -47,7 +47,7 @@ namespace Eval::NNUE::Features {
 
     template <typename T>
     struct CompileTimeList<T> {
-        static constexpr bool Contains(T /*value*/) {
+        static constexpr bool contains(T /*value*/) {
             return false;
         }
         static constexpr std::array<T, 0> kValues = { {} };
@@ -70,7 +70,7 @@ namespace Eval::NNUE::Features {
     struct InsertToSet<T, CompileTimeList<T, First, Remaining...>, AnotherValue> {
         using Result =
             std::conditional_t<
-                CompileTimeList<T, First, Remaining...>::Contains(AnotherValue),
+                CompileTimeList<T, First, Remaining...>::contains(AnotherValue),
                 CompileTimeList<T, First, Remaining...>,
                 std::conditional_t<
                     (AnotherValue < First),
@@ -95,20 +95,23 @@ namespace Eval::NNUE::Features {
        public:
         // Get a list of indices for active features
         template <typename IndexListType>
-        static void AppendActiveIndices(
+        static void append_active_indices(
             const Position& pos, TriggerEvent trigger, IndexListType active[2]) {
 
             for (Color perspective : { WHITE, BLACK }) {
-                Derived::CollectActiveIndices(
+                Derived::collect_active_indices(
                     pos, trigger, perspective, &active[perspective]);
             }
         }
 
         // Get a list of indices for recently changed features
         template <typename PositionType, typename IndexListType>
-        static void AppendChangedIndices(
-            const PositionType& pos, TriggerEvent trigger,
-            IndexListType removed[2], IndexListType added[2], bool reset[2]) {
+        static void append_changed_indices(
+            const PositionType& pos,
+            TriggerEvent trigger,
+            IndexListType removed[2],
+            IndexListType added[2],
+            bool reset[2]) {
 
             const auto& dp = pos.state()->dirtyPiece;
 
@@ -137,10 +140,10 @@ namespace Eval::NNUE::Features {
                 }
 
                 if (reset[perspective]) {
-                    Derived::CollectActiveIndices(
+                    Derived::collect_active_indices(
                         pos, trigger, perspective, &added[perspective]);
                 } else {
-                    Derived::CollectChangedIndices(
+                    Derived::collect_changed_indices(
                         pos, trigger, perspective,
                         &removed[perspective], &added[perspective]);
                 }
@@ -180,20 +183,23 @@ namespace Eval::NNUE::Features {
         static constexpr auto kRefreshTriggers = SortedTriggerSet::kValues;
 
         // Get the feature quantity name
-        static std::string GetName() {
-            return std::string(Head::kName) + "+" + Tail::GetName();
+        static std::string get_name() {
+            return std::string(Head::kName) + "+" + Tail::get_name();
         }
 
     private:
         // Get a list of indices with a value of 1 among the features
         template <typename IndexListType>
-        static void CollectActiveIndices(
-            const Position& pos, const TriggerEvent trigger, const Color perspective,
+        static void collect_active_indices(
+            const Position& pos,
+            const TriggerEvent trigger,
+            const Color perspective,
             IndexListType* const active) {
-            Tail::CollectActiveIndices(pos, trigger, perspective, active);
+
+            Tail::collect_active_indices(pos, trigger, perspective, active);
             if (Head::kRefreshTrigger == trigger) {
                 const auto start = active->size();
-                Head::AppendActiveIndices(pos, perspective, active);
+                Head::append_active_indices(pos, perspective, active);
 
                 for (auto i = start; i < active->size(); ++i) {
                     (*active)[i] += Tail::kDimensions;
@@ -203,14 +209,18 @@ namespace Eval::NNUE::Features {
 
         // Get a list of indices whose values have changed from the previous one in the feature quantity
         template <typename IndexListType>
-        static void CollectChangedIndices(
-            const Position& pos, const TriggerEvent trigger, const Color perspective,
-            IndexListType* const removed, IndexListType* const added) {
-            Tail::CollectChangedIndices(pos, trigger, perspective, removed, added);
+        static void collect_changed_indices(
+            const Position& pos,
+            const TriggerEvent trigger,
+            const Color perspective,
+            IndexListType* const removed,
+            IndexListType* const added) {
+
+            Tail::collect_changed_indices(pos, trigger, perspective, removed, added);
             if (Head::kRefreshTrigger == trigger) {
                 const auto start_removed = removed->size();
                 const auto start_added = added->size();
-                Head::AppendChangedIndices(pos, perspective, removed, added);
+                Head::append_changed_indices(pos, perspective, removed, added);
 
                 for (auto i = start_removed; i < removed->size(); ++i) {
                     (*removed)[i] += Tail::kDimensions;
@@ -251,28 +261,33 @@ namespace Eval::NNUE::Features {
         static constexpr auto kRefreshTriggers = SortedTriggerSet::kValues;
 
         // Get the feature quantity name
-        static std::string GetName() {
+        static std::string get_name() {
             return FeatureType::kName;
         }
 
     private:
         // Get a list of indices for active features
-        static void CollectActiveIndices(
-            const Position& pos, const TriggerEvent trigger, const Color perspective,
+        static void collect_active_indices(
+            const Position& pos,
+            const TriggerEvent trigger,
+            const Color perspective,
             IndexList* const active) {
 
             if (FeatureType::kRefreshTrigger == trigger) {
-              FeatureType::AppendActiveIndices(pos, perspective, active);
+              FeatureType::append_active_indices(pos, perspective, active);
             }
         }
 
         // Get a list of indices for recently changed features
-        static void CollectChangedIndices(
-            const Position& pos, const TriggerEvent trigger, const Color perspective,
-            IndexList* const removed, IndexList* const added) {
+        static void collect_changed_indices(
+            const Position& pos,
+            const TriggerEvent trigger,
+            const Color perspective,
+            IndexList* const removed,
+            IndexList* const added) {
 
             if (FeatureType::kRefreshTrigger == trigger) {
-              FeatureType::AppendChangedIndices(pos, perspective, removed, added);
+              FeatureType::append_changed_indices(pos, perspective, removed, added);
             }
         }
 

src/nnue/features/half_kp.cpp

@@ -30,30 +30,41 @@ namespace Eval::NNUE::Features {
 
     // Find the index of the feature quantity from the king position and PieceSquare
     template <Side AssociatedKing>
-    inline IndexType HalfKP<AssociatedKing>::MakeIndex(
-        Color perspective, Square s, Piece pc, Square ksq) {
+    inline IndexType HalfKP<AssociatedKing>::make_index(
+        Color perspective,
+        Square s,
+        Piece pc,
+        Square ksq) {
 
         return IndexType(orient(perspective, s) + kpp_board_index[pc][perspective] + PS_END * ksq);
     }
 
     // Get a list of indices for active features
     template <Side AssociatedKing>
-    void HalfKP<AssociatedKing>::AppendActiveIndices(
-        const Position& pos, Color perspective, IndexList* active) {
+    void HalfKP<AssociatedKing>::append_active_indices(
+        const Position& pos,
+        Color perspective,
+        IndexList* active) {
+
+        Square ksq = orient(
+            perspective,
+            pos.square<KING>(
+                AssociatedKing == Side::kFriend ? perspective : ~perspective));
 
-        Square ksq = orient(perspective, pos.square<KING>(AssociatedKing == Side::kFriend ? perspective : ~perspective));
         Bitboard bb = pos.pieces() & ~pos.pieces(KING);
         while (bb) {
             Square s = pop_lsb(&bb);
-            active->push_back(MakeIndex(perspective, s, pos.piece_on(s), ksq));
+            active->push_back(make_index(perspective, s, pos.piece_on(s), ksq));
         }
     }
 
     // Get a list of indices for recently changed features
     template <Side AssociatedKing>
-    void HalfKP<AssociatedKing>::AppendChangedIndices(
-        const Position& pos, Color perspective,
-        IndexList* removed, IndexList* added) {
+    void HalfKP<AssociatedKing>::append_changed_indices(
+        const Position& pos,
+        Color perspective,
+        IndexList* removed,
+        IndexList* added) {
 
         Square ksq = orient(
             perspective,
@@ -68,10 +79,10 @@ namespace Eval::NNUE::Features {
                 continue;
 
             if (dp.from[i] != SQ_NONE)
-                removed->push_back(MakeIndex(perspective, dp.from[i], pc, ksq));
+                removed->push_back(make_index(perspective, dp.from[i], pc, ksq));
 
             if (dp.to[i] != SQ_NONE)
-                added->push_back(MakeIndex(perspective, dp.to[i], pc, ksq));
+                added->push_back(make_index(perspective, dp.to[i], pc, ksq));
         }
     }
 

src/nnue/features/half_kp.h

@@ -53,16 +53,21 @@ namespace Eval::NNUE::Features {
             TriggerEvent::kFriendKingMoved : TriggerEvent::kEnemyKingMoved;
 
         // Get a list of indices for active features
-        static void AppendActiveIndices(const Position& pos, Color perspective,
-                                        IndexList* active);
+        static void append_active_indices(
+            const Position& pos,
+            Color perspective,
+            IndexList* active);
 
         // Get a list of indices for recently changed features
-        static void AppendChangedIndices(const Position& pos, Color perspective,
-                                         IndexList* removed, IndexList* added);
+        static void append_changed_indices(
+            const Position& pos,
+            Color perspective,
+            IndexList* removed,
+            IndexList* added);
 
     private:
         // Index of a feature for a given king position and another piece on some square
-        static IndexType MakeIndex(Color perspective, Square s, Piece pc, Square sq_k);
+        static IndexType make_index(Color perspective, Square s, Piece pc, Square sq_k);
     };
 
 }  // namespace Eval::NNUE::Features

src/nnue/features/half_relative_kp.cpp

@@ -11,16 +11,21 @@ namespace Eval::NNUE::Features {
 
     // Find the index of the feature quantity from the ball position and PieceSquare
     template <Side AssociatedKing>
-    inline IndexType HalfRelativeKP<AssociatedKing>::MakeIndex(
-        Color perspective, Square s, Piece pc, Square sq_k) {
+    inline IndexType HalfRelativeKP<AssociatedKing>::make_index(
+        Color perspective,
+        Square s,
+        Piece pc,
+        Square sq_k) {
+
         const IndexType p = IndexType(orient(perspective, s) + kpp_board_index[pc][perspective]);
-        return MakeIndex(sq_k, p);
+        return make_index(sq_k, p);
     }
 
     // Find the index of the feature quantity from the ball position and PieceSquare
     template <Side AssociatedKing>
-    inline IndexType HalfRelativeKP<AssociatedKing>::MakeIndex(
-        Square sq_k, IndexType p) {
+    inline IndexType HalfRelativeKP<AssociatedKing>::make_index(
+        Square sq_k,
+        IndexType p) {
 
         constexpr IndexType W = kBoardWidth;
         constexpr IndexType H = kBoardHeight;
@@ -33,8 +38,10 @@ namespace Eval::NNUE::Features {
 
     // Get a list of indices with a value of 1 among the features
     template <Side AssociatedKing>
-    void HalfRelativeKP<AssociatedKing>::AppendActiveIndices(
-        const Position& pos, Color perspective, IndexList* active) {
+    void HalfRelativeKP<AssociatedKing>::append_active_indices(
+        const Position& pos,
+        Color perspective,
+        IndexList* active) {
 
         Square ksq = orient(
             perspective,
@@ -44,15 +51,17 @@ namespace Eval::NNUE::Features {
         Bitboard bb = pos.pieces() & ~pos.pieces(KING);
         while (bb) {
             Square s = pop_lsb(&bb);
-            active->push_back(MakeIndex(perspective, s, pos.piece_on(s), ksq));
+            active->push_back(make_index(perspective, s, pos.piece_on(s), ksq));
         }
     }
 
     // Get a list of indices whose values ​​have changed from the previous one in the feature quantity
     template <Side AssociatedKing>
-    void HalfRelativeKP<AssociatedKing>::AppendChangedIndices(
-        const Position& pos, Color perspective,
-        IndexList* removed, IndexList* added) {
+    void HalfRelativeKP<AssociatedKing>::append_changed_indices(
+        const Position& pos,
+        Color perspective,
+        IndexList* removed,
+        IndexList* added) {
 
         Square ksq = orient(
             perspective,
@@ -67,10 +76,10 @@ namespace Eval::NNUE::Features {
                 continue;
 
             if (dp.from[i] != SQ_NONE)
-                removed->push_back(MakeIndex(perspective, dp.from[i], pc, ksq));
+                removed->push_back(make_index(perspective, dp.from[i], pc, ksq));
 
             if (dp.to[i] != SQ_NONE)
-                added->push_back(MakeIndex(perspective, dp.to[i], pc, ksq));
+                added->push_back(make_index(perspective, dp.to[i], pc, ksq));
         }
     }
 

src/nnue/features/half_relative_kp.h

@@ -42,18 +42,23 @@ namespace Eval::NNUE::Features {
             TriggerEvent::kFriendKingMoved : TriggerEvent::kEnemyKingMoved;
 
         // Get a list of indices with a value of 1 among the features
-        static void AppendActiveIndices(const Position& pos, Color perspective,
-                                        IndexList* active);
+        static void append_active_indices(
+            const Position& pos,
+            Color perspective,
+            IndexList* active);
 
         // Get a list of indices whose values ​​have changed from the previous one in the feature quantity
-        static void AppendChangedIndices(const Position& pos, Color perspective,
-                                         IndexList* removed, IndexList* added);
+        static void append_changed_indices(
+            const Position& pos,
+            Color perspective,
+            IndexList* removed,
+            IndexList* added);
 
         // Find the index of the feature quantity from the ball position and PieceSquare
-        static IndexType MakeIndex(Square s, IndexType p);
+        static IndexType make_index(Square s, IndexType p);
 
         // Find the index of the feature quantity from the ball position and PieceSquare
-        static IndexType MakeIndex(Color perspective, Square s, Piece pc, Square sq_k);
+        static IndexType make_index(Color perspective, Square s, Piece pc, Square sq_k);
     };
 
 }  // namespace Eval::NNUE::Features

src/nnue/features/k.cpp

@@ -10,29 +10,33 @@ namespace Eval::NNUE::Features {
     }
 
     // Index of a feature for a given king position.
-    IndexType K::MakeIndex(Color perspective, Square s, Color king_color) {
+    IndexType K::make_index(Color perspective, Square s, Color king_color) {
         return IndexType(orient(perspective, s) + bool(perspective ^ king_color) * 64);
     }
 
     // Get a list of indices with a value of 1 among the features
-    void K::AppendActiveIndices(
-        const Position& pos, Color perspective, IndexList* active) {
+    void K::append_active_indices(
+        const Position& pos,
+        Color perspective,
+        IndexList* active) {
 
         for (auto color : Colors) {
-          active->push_back(MakeIndex(perspective, pos.square<KING>(color), color));
+          active->push_back(make_index(perspective, pos.square<KING>(color), color));
         }
     }
 
     // Get a list of indices whose values ​​have changed from the previous one in the feature quantity
-    void K::AppendChangedIndices(
-        const Position& pos, Color perspective,
-        IndexList* removed, IndexList* added) {
+    void K::append_changed_indices(
+        const Position& pos,
+        Color perspective,
+        IndexList* removed,
+        IndexList* added) {
 
         const auto& dp = pos.state()->dirtyPiece;
         if (type_of(dp.piece[0]) == KING)
         {
-            removed->push_back(MakeIndex(perspective, dp.from[0], color_of(dp.piece[0])));
-            added->push_back(MakeIndex(perspective, dp.to[0], color_of(dp.piece[0])));
+            removed->push_back(make_index(perspective, dp.from[0], color_of(dp.piece[0])));
+            added->push_back(make_index(perspective, dp.to[0], color_of(dp.piece[0])));
         }
     }
 

src/nnue/features/k.h

@@ -8,36 +8,41 @@
 //Definition of input feature quantity K of NNUE evaluation function
 namespace Eval::NNUE::Features {
 
-  // Feature K: Ball position
-  class K {
-  public:
-      // feature quantity name
-      static constexpr const char* kName = "K";
+    // Feature K: Ball position
+    class K {
+    public:
+        // feature quantity name
+        static constexpr const char* kName = "K";
 
-      // Hash value embedded in the evaluation function file
-      static constexpr std::uint32_t kHashValue = 0xD3CEE169u;
+        // Hash value embedded in the evaluation function file
+        static constexpr std::uint32_t kHashValue = 0xD3CEE169u;
 
-      // number of feature dimensions
-      static constexpr IndexType kDimensions = SQUARE_NB * 2;
+        // number of feature dimensions
+        static constexpr IndexType kDimensions = SQUARE_NB * 2;
 
-      // The maximum value of the number of indexes whose value is 1 at the same time among the feature values
-      static constexpr IndexType kMaxActiveDimensions = 2;
+        // The maximum value of the number of indexes whose value is 1 at the same time among the feature values
+        static constexpr IndexType kMaxActiveDimensions = 2;
 
-      // Timing of full calculation instead of difference calculation
-      static constexpr TriggerEvent kRefreshTrigger = TriggerEvent::kNone;
+        // Timing of full calculation instead of difference calculation
+        static constexpr TriggerEvent kRefreshTrigger = TriggerEvent::kNone;
 
-      // Get a list of indices with a value of 1 among the features
-      static void AppendActiveIndices(const Position& pos, Color perspective,
-                                      IndexList* active);
+        // Get a list of indices with a value of 1 among the features
+        static void append_active_indices(
+            const Position& pos,
+            Color perspective,
+            IndexList* active);
 
-      // Get a list of indices whose values ​​have changed from the previous one in the feature quantity
-      static void AppendChangedIndices(const Position& pos, Color perspective,
-                                       IndexList* removed, IndexList* added);
+        // Get a list of indices whose values ​​have changed from the previous one in the feature quantity
+        static void append_changed_indices(
+            const Position& pos,
+            Color perspective,
+            IndexList* removed,
+            IndexList* added);
 
-  private:
-      // Index of a feature for a given king position.
-      static IndexType MakeIndex(Color perspective, Square s, Color king_color);
-  };
+    private:
+        // Index of a feature for a given king position.
+        static IndexType make_index(Color perspective, Square s, Color king_color);
+    };
 
 }  // namespace Eval::NNUE::Features
 

src/nnue/features/p.cpp

@@ -10,26 +10,30 @@ namespace Eval::NNUE::Features {
     }
 
     // Find the index of the feature quantity from the king position and PieceSquare
-    inline IndexType P::MakeIndex(
+    inline IndexType P::make_index(
         Color perspective, Square s, Piece pc) {
         return IndexType(orient(perspective, s) + kpp_board_index[pc][perspective]);
     }
 
     // Get a list of indices with a value of 1 among the features
-    void P::AppendActiveIndices(
-        const Position& pos, Color perspective, IndexList* active) {
+    void P::append_active_indices(
+        const Position& pos,
+        Color perspective,
+        IndexList* active) {
 
         Bitboard bb = pos.pieces() & ~pos.pieces(KING);
         while (bb) {
             Square s = pop_lsb(&bb);
-            active->push_back(MakeIndex(perspective, s, pos.piece_on(s)));
+            active->push_back(make_index(perspective, s, pos.piece_on(s)));
         }
     }
 
     // Get a list of indices whose values ​​have changed from the previous one in the feature quantity
-    void P::AppendChangedIndices(
-        const Position& pos, Color perspective,
-        IndexList* removed, IndexList* added) {
+    void P::append_changed_indices(
+        const Position& pos,
+        Color perspective,
+        IndexList* removed,
+        IndexList* added) {
 
         const auto& dp = pos.state()->dirtyPiece;
         for (int i = 0; i < dp.dirty_num; ++i) {
@@ -39,10 +43,10 @@ namespace Eval::NNUE::Features {
               continue;
 
             if (dp.from[i] != SQ_NONE)
-              removed->push_back(MakeIndex(perspective, dp.from[i], pc));
+              removed->push_back(make_index(perspective, dp.from[i], pc));
 
             if (dp.to[i] != SQ_NONE)
-              added->push_back(MakeIndex(perspective, dp.to[i], pc));
+              added->push_back(make_index(perspective, dp.to[i], pc));
         }
     }
 

src/nnue/features/p.h

@@ -8,36 +8,41 @@
 //Definition of input feature P of NNUE evaluation function
 namespace Eval::NNUE::Features {
 
-  // Feature P: PieceSquare of pieces other than balls
-  class P {
-  public:
-      // feature quantity name
-      static constexpr const char* kName = "P";
+    // Feature P: PieceSquare of pieces other than balls
+    class P {
+    public:
+        // feature quantity name
+        static constexpr const char* kName = "P";
 
-      // Hash value embedded in the evaluation function file
-      static constexpr std::uint32_t kHashValue = 0x764CFB4Bu;
+        // Hash value embedded in the evaluation function file
+        static constexpr std::uint32_t kHashValue = 0x764CFB4Bu;
 
-      // number of feature dimensions
-      static constexpr IndexType kDimensions = PS_END;
+        // number of feature dimensions
+        static constexpr IndexType kDimensions = PS_END;
 
-      // The maximum value of the number of indexes whose value is 1 at the same time among the feature values
-      static constexpr IndexType kMaxActiveDimensions = 30; // Kings don't count
+        // The maximum value of the number of indexes whose value is 1 at the same time among the feature values
+        static constexpr IndexType kMaxActiveDimensions = 30; // Kings don't count
 
-      // Timing of full calculation instead of difference calculation
-      static constexpr TriggerEvent kRefreshTrigger = TriggerEvent::kNone;
+        // Timing of full calculation instead of difference calculation
+        static constexpr TriggerEvent kRefreshTrigger = TriggerEvent::kNone;
 
-      // Get a list of indices with a value of 1 among the features
-      static void AppendActiveIndices(const Position& pos, Color perspective,
-                                      IndexList* active);
+        // Get a list of indices with a value of 1 among the features
+        static void append_active_indices(
+            const Position& pos,
+            Color perspective,
+            IndexList* active);
 
-      // Get a list of indices whose values ​​have changed from the previous one in the feature quantity
-      static void AppendChangedIndices(const Position& pos, Color perspective,
-                                       IndexList* removed, IndexList* added);
+        // Get a list of indices whose values ​​have changed from the previous one in the feature quantity
+        static void append_changed_indices(
+            const Position& pos,
+            Color perspective,
+            IndexList* removed,
+            IndexList* added);
 
-  private:
-      // Index of a feature for a given piece on some square
-      static IndexType MakeIndex(Color perspective, Square s, Piece pc);
-  };
+    private:
+        // Index of a feature for a given piece on some square
+        static IndexType make_index(Color perspective, Square s, Piece pc);
+    };
 
 }  // namespace Eval::NNUE::Features